Skip to content

Fix privSz for wp_dh_get_params #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
padelsbach merged 2 commits into from
Aug 7, 2025
Merged

Fix privSz for wp_dh_get_params #251

padelsbach merged 2 commits into from
Aug 7, 2025

Conversation

@aidangarske
Copy link
Contributor

@aidangarske aidangarske commented Aug 6, 2025 •
edited
Loading

Description

  • wp_dh_get_params was returning the pub key size when it should return the private key size here.
  • Added a test case for NULL data entries for size queries. Before we where not actually hitting this line in the unit test.
  • Private key size queries with NULL where actually failing as well like this:
#### Start: 57 - test_dh_get_params
MSG: EVP_PKEY_get_params failed for param priv in mode Null data (WolfProvider (0))
#### FAILED: 57 - test_dh_get_params (err: 1)

@aidangarske aidangarske requested a review from padelsbach August 6, 2025 20:40
@aidangarske aidangarske self-assigned this Aug 6, 2025
@padelsbach
Copy link
Contributor

padelsbach commented Aug 6, 2025

Good catch!

@padelsbach
Copy link
Contributor

padelsbach commented Aug 6, 2025

Is there a test case we should add for this?

@aidangarske aidangarske marked this pull request as ready for review August 6, 2025 23:49
padelsbach
padelsbach approved these changes Aug 7, 2025
View reviewed changes
Copy link
Contributor

@padelsbach padelsbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job

@padelsbach padelsbach merged commit e773a7d into wolfSSL:master Aug 7, 2025
282 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@padelsbach padelsbach padelsbach approved these changes

@ColtonWilley ColtonWilley Awaiting requested review from ColtonWilley

@SparkiDev SparkiDev Awaiting requested review from SparkiDev

Assignees

@aidangarske aidangarske

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aidangarske @padelsbach